You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎯 Main theme: Updating ENTSO-E parser to use a new proxy service
📝 PR summary: This PR updates the ENTSO-E parser to use a new proxy service. It simplifies the code by removing the need to shuffle and try multiple tokens, and instead uses a single token for the new proxy service. It also updates the script ENTSOE_capacity_update.py to reflect this change.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱️ Estimated effort to review [1-5]: 2, because the changes are straightforward and mainly involve updating URLs and removing redundant code.
🔒 Security concerns: No
PR Feedback
💡 General suggestions: The changes in this PR are clear and straightforward. However, it would be beneficial to add tests to ensure that the new proxy service works as expected. This could include tests to check the response from the new proxy service and handle any potential errors.
🤖 Code feedback:
relevant file
parsers/ENTSOE.py
suggestion
Consider handling the case where the get_token function returns None. Currently, if get_token returns None, it will be passed as a parameter to the session.get call, which may lead to unexpected behavior. [important]
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.
See the tools guide for more details.
To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.
There was a reason the checklist had two boxes though 😉
Haha, I've always just read the "pnpm ..." and assumed it was only about frontend 😅
Also thought we had pre-commit running for contrib, but seems like we never add ruff to the checks? What's missing from replacing isort and black completely there?
Looks like it's working perfectly!
There was a reason the checklist had two boxes though 😉
Haha, I've always just read the "pnpm ..." and assumed it was only about frontend 😅 Also thought we had pre-commit running for contrib, but seems like we never add ruff to the checks? What's missing from replacing isort and black completely there?
Pretty sure I uninstalled isort and black, I don't think we ever had all of them in there since they where so slow...
Looks like it's working perfectly!
There was a reason the checklist had two boxes though 😉
Haha, I've always just read the "pnpm ..." and assumed it was only about frontend 😅 Also thought we had pre-commit running for contrib, but seems like we never add ruff to the checks? What's missing from replacing isort and black completely there?
Pretty sure I uninstalled isort and black, I don't think we ever had all of them in there since they where so slow...
On the monorepo we still run isort and black on pre-commit, so maybe it's time to replace that :)
Looks like it's working perfectly!
There was a reason the checklist had two boxes though 😉
Haha, I've always just read the "pnpm ..." and assumed it was only about frontend 😅 Also thought we had pre-commit running for contrib, but seems like we never add ruff to the checks? What's missing from replacing isort and black completely there?
Pretty sure I uninstalled isort and black, I don't think we ever had all of them in there since they where so slow...
On the monorepo we still run isort and black on pre-commit, so maybe it's time to replace that :)
Yeah, I noticed we where still using black, led to some frustration when there was minor differences between ruff and black and I had autosave and format on save on and ruff as the default 😅.
But I can take care of the pre-commit hook in here, then we can start replacing things on the backend too.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Description
Changes ENTSO-E parser to query via a new proxy service.
Double check
poetry run test_parser "zone_key"